Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix DataFrame.replace and DataFrame.set_index docstrings #23939

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Nov 27, 2018

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Based on #22459. Fix the docstring for DataFrame.replace and DataFrame.set_index. I put them together since set_index was quite simple: there was two Returns sections.

I also updated ci/code_checks.sh. DataFrame.stack was already correct.

@pep8speaks
Copy link

Hello @Moisan! Thanks for submitting the PR.

@Moisan Moisan changed the title DOC: fix DataFrame.replace and DataFrame.set_index DOC: fix DataFrame.replace and DataFrame.set_index docstrings Nov 27, 2018
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #23939 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23939   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51501    51501           
=======================================
  Hits        47534    47534           
  Misses       3967     3967
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 42.42% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.02% <ø> (ø) ⬆️
pandas/core/generic.py 96.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede0dae...c46c012. Read the comment docs.

@jreback jreback added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 27, 2018
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Moisan

@jreback jreback added this to the 0.24.0 milestone Nov 29, 2018
@jreback jreback merged commit 8ed347a into pandas-dev:master Nov 29, 2018
@jreback
Copy link
Contributor

jreback commented Nov 29, 2018

thanks @Moisan

@Moisan Moisan deleted the docstring_replace branch December 2, 2018 11:33
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants